Admin views csv upload #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the temporary view for showing a CsvUpload record. I added that view just so I could have somewhere for the create page to redirect to but I wanted to return to it next. Here's how it looks:
I was all set to use the existing pattern of doing a DL for the key/values for the model but then I realized that I'd rather just have a table. So I took a step back and found the places I was using the DL and updated them to use a table. Then I extracted a partial and moved the logic for what's in that table up into the models.
Then I was able to return to the CsvUpload show view and easily implement something that I think looks much better.