Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ui):Added Cooking Pot Svg and cooking time #791

Closed
wants to merge 5 commits into from
Closed

(ui):Added Cooking Pot Svg and cooking time #791

wants to merge 5 commits into from

Conversation

0xSaksham
Copy link
Contributor

image

Working on the Cooking Time, open to reviews and questions
Completes #767

@theborakompanioni theborakompanioni changed the base branch from master to devel July 8, 2024 14:43
@theborakompanioni
Copy link
Collaborator

Hey @0xSaksham! Is it planned to add animation in this PR?

@0xSaksham
Copy link
Contributor Author

No, I'll create a different PR for that.

What I plan is to add a cooking time. Does it sound good?

@theborakompanioni
Copy link
Collaborator

No, I'll create a different PR for that.

What I plan is to add a cooking time. Does it sound good?

Let's leave out the concept of "cooking time" till we have a good understanding if that is even feasible. As stated in the description, waiting time is just the minimum estimation. I'd rather not display it for now. Okay for you, if it is removed (for now)?

@0xSaksham
Copy link
Contributor Author

Let's leave out the concept of "cooking time" till we have a good understanding if that is even feasible.

Sure than I'll remove it then.

@0xSaksham
Copy link
Contributor Author

@theborakompanioni removed cooking time.

@0xSaksham
Copy link
Contributor Author

Done!

@0xSaksham
Copy link
Contributor Author

image

This looks okay?

@0xSaksham
Copy link
Contributor Author

@theborakompanioni please take a look.

Everything we talked about is done now.

@theborakompanioni
Copy link
Collaborator

@theborakompanioni please take a look.

Everything we talked about is done now.

Nice. Only thing left is making it work in light mode 😉

@0xSaksham
Copy link
Contributor Author

Okay sir!

@theborakompanioni theborakompanioni mentioned this pull request Jul 22, 2024
Closed
@0xSaksham
Copy link
Contributor Author

#804 PR has all the required changes and DRYer code.

@0xSaksham 0xSaksham self-assigned this Aug 27, 2024
@0xSaksham 0xSaksham added the UI/UX Issue related to cosmetics, design, or user experience label Aug 27, 2024
@0xSaksham 0xSaksham added this to the SoB milestone Aug 27, 2024
@0xSaksham 0xSaksham closed this Aug 27, 2024
@0xSaksham 0xSaksham deleted the cooking-pot branch August 27, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@editwentyone editwentyone Awaiting requested review from editwentyone

@barrytra barrytra Awaiting requested review from barrytra

@amitx13 amitx13 Awaiting requested review from amitx13

@theborakompanioni theborakompanioni Awaiting requested review from theborakompanioni

Assignees

@0xSaksham 0xSaksham

Labels
UI/UX Issue related to cosmetics, design, or user experience
Projects
JAM
Status: Done ✅
Milestone
SoB
Development

Successfully merging this pull request may close these issues.
2 participants
@0xSaksham @theborakompanioni