-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: validate wallet name #684
Conversation
Why not also allow hyphen-minus ( |
Now also allows hyphens. Error feedback message has been changed to
Additionally, the length of the wallet name has been limited to Thanks for the feedback @kristapsk 🙏 |
Interesting, something to test and likely fix in JM. |
With which OS, filesystem and Python version do you experienced this? I cannot reproduce under Linux, ext4 and Python 3.11.4, at least not with cli tools. You had this both with scripts and RPC API or only RPC API? |
Hey @kristapsk! (Mostly) everything I do and test is with the RPC API! |
Resolves #683.
Before this commit, the wallet name has been validated only on the backend.
After this commit is applied, it will also be validated by the frontend.
The validation is a bit more strict than "necessary", only numbers, letters and
_
(underscore) will be allowed from now on.