feat: renew fidelity bond #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
force-pushed
the
feat/renew-fb
branch
from
ddff0ae to
e13eb1f
Compare
theborakompanioni
force-pushed
the
feat/renew-fb
branch
2 times, most recently
from
675a4ae to
658c39d
Compare
theborakompanioni
force-pushed
the
feat/renew-fb
branch
from
b830558 to
7401ce8
Compare
editwentyone
approved these changes
Nov 2, 2023
|
I am inclined to hide this behind a feature toggle till users can specify the tx fee directly when JoinMarket-Org/joinmarket-clientserver#1360 is implemented. (There is a workaround by temporarily setting the txfee via |
theborakompanioni
added
the
blocked
|
Revert to draft - blocked till JoinMarket-Org/joinmarket-clientserver#1597 is tested and merged. |
kristapsk
added a commit
to JoinMarket-Org/joinmarket-clientserver
that referenced
this pull request
Nov 22, 2023
d8f1fc4 Add optional txfee property for direct-send wallet RPC (Kristaps Kaupe) Pull request description: Resolves #1360. Jam wants it for joinmarket-webui/jam#678. ACKs for top commit: AdamISZ: tACK d8f1fc4 Tree-SHA512: aa5afc17c0a39d65094c69d847841295c101ed74518be25610378aa7eda95ee3e609f7ae49be75c3e9d148dd8f7787ac1ccc17aa8ee624d1cef3508fa70af114
theborakompanioni
force-pushed
the
feat/renew-fb
branch
from
7401ce8 to
d691e37
Compare
|
nice, one little thing: remove cancel button in this dialog
|
theborakompanioni
force-pushed
the
feat/renew-fb
branch
from
d691e37 to
ae35695
Compare
theborakompanioni
force-pushed
the
feat/renew-fb
branch
2 times, most recently
from
6d030dc to
8608ce2
Compare
|
Unblocked. This can now be tackled once again. |
theborakompanioni
removed
the
blocked
theborakompanioni
force-pushed
the
feat/renew-fb
branch
from
8608ce2 to
f202725
Compare
|
nice, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #610
Adds the ability to renew an expired fidelity bond.
This will be done with a direct-send creating a "single input, single output transaction" (this might not be what more advanced users want - e.g. CPFP is not possible afterwards). Feedback welcome.
In addition, the "Create FB" confirm dialog will now display the fee settings for the user to review before actually creating the bond.
📸
Expired fidelity bond (Before/After)
Renew fidelity bond flow
On Error
"Create fidelity bond" Confirm Modal (Before/After)
How to test
npm run dev:start)