Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not preselect jar on send page #676

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

theborakompanioni
Copy link
Collaborator

Before this commit, the first funded jar has been preselected as source jar.
After this commit, no jar will be preselected.

This was a request by @editwentyone.

Additionally, it fixes a strange bug: Scrolling to the top of the page did not work properly in all browsers.

@theborakompanioni theborakompanioni added concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience labels Oct 11, 2023
@theborakompanioni theborakompanioni self-assigned this Oct 11, 2023
@theborakompanioni theborakompanioni marked this pull request as ready for review October 11, 2023 21:28
Copy link

@editwentyone editwentyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running as expected, even when you trick yourself and select target A before source A ^^

@theborakompanioni theborakompanioni merged commit fcf23a9 into master Oct 12, 2023
1 of 2 checks passed
@theborakompanioni theborakompanioni deleted the chore/do-not-preselect-jar branch October 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concept Wild idea, or too many details unknown yet UI/UX Issue related to cosmetics, design, or user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants