-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new authentication mechanism (access/refresh token) #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theborakompanioni
force-pushed
the
feat/663-auth
branch
from
September 23, 2023 07:33
1625647
to
c8a167e
Compare
Just a heads-up: Websocket auth not addressed yet. |
theborakompanioni
force-pushed
the
feat/663-auth
branch
from
September 29, 2023 08:24
f4811da
to
470cb80
Compare
Commit was temporarily till the new auth mechanism can be handled. This reverts commit c31ba67.
Worked out-of-the-box in my tests. 🙌 |
Ready for review. |
worked smooth on my side in dev env |
editwentyone
approved these changes
Oct 6, 2023
We definitely need more reviewers and testers. Someone also needs to audit at the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #663.
This PR adds handling for the new JWT auth mechanism.
From JSON-RPC-API-using-jmwalletd.md#rules-about-making-requests:
The token is refreshed every 22.5 minutes (30min * 0.75). In dev mode more often (every 60 seconds).
There is currently a problem upstream with handling wallets that contain spaces in their filename, should be fixed with JoinMarket-Org/joinmarket-clientserver#1562. Nonetheless, the code can already be reviewed and should not be affected by the changes.
How to test
Rebuild the dev docker environment
npm run regtest:rebuild
and verify:Misc
Api.Helper.parseAuthProps
is temporary and can be removed in refactor: Use typed responses for api calls #670.master
again.