wip

join-com · Nov 14, 2018 · 24aac6f · 24aac6f
1 parent 0dc743a
commit 24aac6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/generator/generator.go b/generator/generator.go
@@ -623,7 +623,7 @@ func (g *generator) generateImplementation(service *google_protobuf.ServiceDescr
 		g.P("* @deprecated")
 		g.P("*/")
 	}
-	g.P(fmt.Sprintf("export interface %sImplementation extends grpcts.Implementations {", gen.CamelCase(*service.Name)))
+	g.P(fmt.Sprintf("export interface I%sImplementation extends grpcts.Implementations {", gen.CamelCase(*service.Name)))
 
 	for _, method := range service.Method {
 		g.methodDeprecated(method)
@@ -655,7 +655,7 @@ func (g *generator) generateClient(service *google_protobuf.ServiceDescriptorPro
 		g.P("*/")
 	}
 	g.P(fmt.Sprintf("export class %sClient extends grpcts.Client {", gen.CamelCase(*service.Name)))
-	g.P("constructor(address: string, credentials: grpc.ChannelCredentials, trace: grpcts.ClientTrace = nodeTrace, options?: object){")
+	g.P("constructor(address: string, credentials?: grpc.ChannelCredentials, trace: grpcts.ClientTrace = nodeTrace, options?: object){")
 	g.P(fmt.Sprintf("super(%sServiceDefinition, address, credentials, trace, options);", g.toLowerFirst(*service.Name)))
 	g.P("}")
 	for _, method := range service.Method {

diff --git a/integrationTests/__tests__/generated/Test.ts b/integrationTests/__tests__/generated/Test.ts
@@ -950,7 +950,7 @@ export namespace Foo {
     }
   };
 
-  export interface UsersImplementation extends grpcts.Implementations {
+  export interface IUsersImplementation extends grpcts.Implementations {
     /**
      * @deprecated
      */
-Original file line number
+Diff line change
@@ Expand Up / @@ -950,7 +950,7 @@ export namespace Foo { @@
         }
       };
-      export interface UsersImplementation extends grpcts.Implementations {
+      export interface IUsersImplementation extends grpcts.Implementations {
         /**
          * @deprecated
          */
@@ Expand Down @@