fix: if a line contains multiple # characters, there will be issues w… #238
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen traversing from back to front
ccoVeille
reviewed
Dec 15, 2024
| // a comment (ie asdasd # some comment) | ||
| for i := endOfVar - 1; i >= 0; i-- { | ||
| if line[i] == charComment && i > 0 { | ||
| // a comment (ie asdasd # some comment # other) |
There was a problem hiding this comment.
I would like to suggest this, because what you add increase the confusion
Suggested change
| // a comment (ie asdasd # some comment # other) | |
| // a comment (ie `whatever # some comment # other`) |
Or any variation
Suggested change
| // a comment (ie asdasd # some comment # other) | |
| // a comment, ie: `whatever # some comment # other` |
Or
Suggested change
| // a comment (ie asdasd # some comment # other) | |
| // a comment, ie: whatever # some comment # other |
Because asdasd is unclear. I know the comment is not yours, and you are only moving it. But now, the confusion is increased.
I mean, I'm not even sure if whatever should be whatever , foo=bar
ccoVeille
reviewed
Dec 15, 2024
| @@ -1,4 +1,6 @@ | |||
| # Full line comment | |||
| qux=thud # fred # other | |||
| thud=fred#qux # other | |||
There was a problem hiding this comment.
Because a later refactoring could break expected behavior
I would like you to add this, and test it
Suggested change
| thud=fred#qux # other | |
| thud=fred#qux # other | |
| quz=foo#baz # other # more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When traversing from back to front, an error occurs if a line contains multiple # characters, such as bar=foo # baz # other. I changed it to traverse from front to back instead.