feat: add support for embedded command evaluation #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joho shameless self bump |
|
I'm probably not the best person to review this. I don't have anything to do with this library and I commented on that previous PR because at the time I had an issue with it for the service I was maintaining but it was easier to just remove this library and make everyone use Docker Compose instead. |
Thank you for the reply anyway though, hopefully it'll grab some attention 😅 |
|
Hi @the-wondersmith, love that you emailed in to my work's customer support team to nudge me here. I won't be accepting this PR per #182 |
|
|
That's a new level of stalking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly updated refactoring of the work done in #55, with the previously voiced concerns addressed and basic windows support added