Only toggle the menu dialogues when flipping the board through the menu.

johndoknjas · Jan 17, 2025 · 9ac6509 · 9ac6509
1 parent 10c6c3e
commit 9ac6509
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/ui/analyse/src/ctrl.ts b/ui/analyse/src/ctrl.ts
@@ -274,7 +274,6 @@ export default class AnalyseCtrl {
     this.explorer.onFlip();
     this.onChange();
     this.persistence?.save(true);
-    this.actionMenu.toggle();
     this.redraw();
   };
 

diff --git a/ui/analyse/src/view/actionMenu.ts b/ui/analyse/src/view/actionMenu.ts
@@ -91,7 +91,14 @@ export function view(ctrl: AnalyseCtrl): VNode {
     h('div.action-menu__tools', [
       h(
         'a',
-        { hook: bind('click', ctrl.flip), attrs: { 'data-icon': licon.ChasingArrows, title: 'Hotkey: f' } },
+        {
+          hook: bind('click', () => {
+            ctrl.flip();
+            ctrl.actionMenu.toggle();
+            ctrl.redraw();
+          }),
+          attrs: { 'data-icon': licon.ChasingArrows, title: 'Hotkey: f' },
+        },
         i18n.site.flipBoard,
       ),
       !ctrl.ongoing &&

diff --git a/ui/round/src/ctrl.ts b/ui/round/src/ctrl.ts
@@ -289,7 +289,6 @@ export default class RoundController implements MoveRootCtrl {
       orientation: boardOrientation(this.data, this.flip),
     });
     pubsub.emit('flip', this.flip);
-    this.menu.toggle();
     this.redraw();
   };
 

diff --git a/ui/round/src/view/boardMenu.ts b/ui/round/src/view/boardMenu.ts
@@ -10,7 +10,12 @@ export default function (ctrl: RoundController): LooseVNode {
     const d = ctrl.data,
       spectator = d.player.spectator;
     return [
-      h('section', [menu.flip(i18n.site.flipBoard, ctrl.flip, ctrl.flipNow)]),
+      h('section', [
+        menu.flip(i18n.site.flipBoard, ctrl.flip, () => {
+          ctrl.flipNow();
+          ctrl.menu.toggle();
+        }),
+      ]),
       h('section', [
         menu.zenMode(true),
         menu.blindfold(