Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use features of find command in test.sh #63

Closed
wants to merge 4 commits into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 4, 2023

find schemas/ -type f -name "*.json" -not -path "$file" -printf ' -r %p'

And break ajv options to separate lines.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jul 14, 2024

@johnbillion Friendly ping 🏓

@szepeviktor
Copy link
Contributor Author

@johnbillion This PR seems to be an anti-john one.

@johnbillion
Copy link
Owner

On my local machine I get an error when running composer test with this change:

find: -printf: unknown primary or operator

I can't see an advantage to this change. The current code works fine as it is.

@szepeviktor
Copy link
Contributor Author

All right. I am not a businessman but a little scientist.

The -printf option is not in POSIX find. It is a feature of GNU find, e.g., on Linux.

@szepeviktor szepeviktor deleted the patch-1 branch November 14, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants