Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: matchbox_server docker image GitHub action #420

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Feature: matchbox_server docker image GitHub action #420

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2c0cfb1
feat: add github action to build and push matchbox server
AgustinRamiroDiaz Feb 18, 2024
bb1ed5f
change username to be a variable
AgustinRamiroDiaz Feb 18, 2024
a5bde14
fix: update dockerfile path
AgustinRamiroDiaz Feb 18, 2024
953809b
add buildx for cache
AgustinRamiroDiaz Feb 18, 2024
fc668e8
improvement: build better tags
AgustinRamiroDiaz Feb 18, 2024
819beb6
fix: run code action in v* tags
AgustinRamiroDiaz Mar 28, 2024
1583749
improvement: merge workflows
AgustinRamiroDiaz Mar 28, 2024
3490131
Merge branch 'johanhelsing:main' into feature/github-actions
AgustinRamiroDiaz Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions .github/workflows/code.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ on:
push:
branches:
- main
tags:
- "v*"
pull_request:

name: Code
Expand Down Expand Up @@ -73,7 +75,6 @@ jobs:
- name: Run cargo clippy
run: cargo fmt --all --check


lint-native:
name: Lints native
strategy:
Expand Down Expand Up @@ -115,14 +116,14 @@ jobs:

- name: Run cargo clippy
run: RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy >
--all-targets
--target wasm32-unknown-unknown
-p matchbox_socket
-p bevy_matchbox
-p bevy_ggrs_example
-p simple_example
--
-D warnings
--all-targets
--target wasm32-unknown-unknown
-p matchbox_socket
-p bevy_matchbox
-p bevy_ggrs_example
-p simple_example
--
-D warnings

server-container:
name: Build & Push Server Container
Expand All @@ -145,11 +146,19 @@ jobs:
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Login to Docker Hub
uses: docker/login-action@v3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at least some of these steps should have:

if: startsWith(github.ref, 'refs/tags/')

with:
username: ${{ vars.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Docker Metadata
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ env.IMAGE_REPOSITORY }}
images: |
${{ env.IMAGE_REPOSITORY }}
${{ vars.DOCKERHUB_USERNAME }}/matchbox_server
tags: |
type=ref,event=tag
type=raw,value=latest
Expand Down
36 changes: 0 additions & 36 deletions .github/workflows/push-matchbox_server-dockerhub.yml
View file
Open in desktop

This file was deleted.

Loading