Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision dependencies and fix compile errors for bevy 0.13 #26

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

sbesh91
Copy link
Contributor

@sbesh91 sbesh91 commented Feb 19, 2024

Quick PR here to ensure bevy 0.13 support

  • Update dependencies in line with bevy 0.13
  • Pin web_sys to the same version as bevy 0.13
  • Use .into() to fix compile errors that surfaced after library upgrades

PS: my formatter seems to have run on the cargo.toml

@johanhelsing
Copy link
Owner

Thanks! What's the purpose of bumping web-sys?

@sbesh91
Copy link
Contributor Author

sbesh91 commented Feb 20, 2024

Thanks! What's the purpose of bumping web-sys?

In some conversation with folks in the Bevy discord they mentioned that they pin the version of web_sys because they don't follow semver with that package. I thought following that practice would be reasonable to do.

@johanhelsing
Copy link
Owner

Gotcha. I think what's done in this pr is just bumping the minimum requirement.

I think this would have been worked perfectly fine and handled automatically by cargo without that change, because bevy would then be the most specific dependency. If my understanding is correct.

It probably doesn't matter, but i just wanted to understand whats happening. Thanks for explaining.

@sbesh91
Copy link
Contributor Author

sbesh91 commented Feb 20, 2024

Gotcha. I think what's done in this pr is just bumping the minimum requirement.

I think this would have been worked perfectly fine and handled automatically by cargo without that change, because bevy would then be the most specific dependency. If my understanding is correct.

It probably doesn't matter, but i just wanted to understand whats happening. Thanks for explaining.

Thanks for the explanation on your end 💯

I don't have access to merge this with your approval, so I think you'll have to do that when you're ready.

@johanhelsing johanhelsing merged commit 3309c2a into johanhelsing:main Feb 20, 2024
3 checks passed
@sbesh91
Copy link
Contributor Author

sbesh91 commented Feb 20, 2024

@johanhelsing are you able to trigger a release and new version? I didn't remember to do that in this PR. Sorry about that.

@johanhelsing
Copy link
Owner

Yep. Planning to do releases of this one and most of my crates tomorrow.

@sbesh91
Copy link
Contributor Author

sbesh91 commented Feb 21, 2024

Yep. Planning to do releases of this one and most of my crates tomorrow.

Thank you!

@johanhelsing
Copy link
Owner

@sbesh91 done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants