fix for folders not containing any files but containing other folders #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you take a look at a few things:
|
|
fix for folders not containing any files but containing other folders, Travis test passed (space was missing) |
|
Great thanks! Can you add a test proving that this functionality works? |
|
@losrebellos ping! I'd like to merge this functionality, but a test would really help, and this is no longer directly mergable :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a folder doesn't contain any files, remapify throws an error as aliasWithNoExt is null.
Folders can be empty of files but can contains other folders (which won't be empty), especially if you're working on a package or library.