add pink theme, convert hard-coded color names to variables #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this hasn't been approved yet but do you mind if I start working on one of the existing issues? |
|
Please go ahead. I'll review this as soon as I can :) |
|
Cool. Is there an existing issue that needs some love? I could maybe tackle #6 ? |
|
Hi, I was wondering if you mind if I start another theme for this? I've been working on this Catppuccin palette project and I'd love to make a risotto theme for it. If you don't like this pink one you can cancel it, but it would be nice to have the changes to the variables in it, maybe a separate PR? |
|
Breaking variable changes off into new PR. |
|
@rio-codes Sorry for the slow response. Both the pink and Catppuccin palettes are very welcome, if you still want to contribute them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a pink palette and mode for risotto. I also modified logo.css and typography.css to use variables instead of hard-coded colors from the existing palettes, making it easier to add new palettes and modes in the future. Finally, I changed the existing dark and light mode files to use the original colors.