Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optimized TotpRowView #68

Merged
merged 2 commits into from
Sep 28, 2024
Merged

fix: Optimized TotpRowView #68

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93703a8
Optimised when otp are updated
joeldavidw Sep 28, 2024
7bcc3ee
Fixed lint
joeldavidw Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions Chronos/App/Tabs/Tokens/Row/TOTPRowView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ struct TOTPRowView: View {
.fontWeight(.light)
.lineLimit(1)
.onAppear(perform: updateOtp)
.onReceive(timer) { _ in
updateOtp()
}

Spacer()

Expand Down Expand Up @@ -64,6 +61,10 @@ struct TOTPRowView: View {
// Circle progress will look smooth; however, the high redraw count causes significant CPU load.
// progress = timeLeft / Double(token.period)
progress = Double(secsLeft) / Double(token.period)

if secsLeft == token.period {
updateOtp()
}
}

private func formatOtp(otp: String) -> String {
Expand Down