Introducing logfile checksumming + various fixes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Furure-prrofing: Don't rely on groups/build-deps when source is not from the repos. Source dependencies might differ from repo dependencies/groups. This is the case when e.g. MariaDB in repo is a different branch than the source.
On systems that don't have /usr/bin/python, use /usr/bin/python3. Call /usr/bin/python(3) instead of /usr/bin/env python in speedtest-cli because 'python' might not be present.
Many mirrors don't keep older source version around. downloads.mariadb.com does.
Some versions of gcc (currently those distributed with Ubuntu Bionic and Debian Stretch) segfault when compiling mroonga db, so omit it. Compiling still is sufficiently complex without it.
Syntax between sysbench 1.x and 0.4.x is very different. Using sysbench 1.x from upstream directly ensures consistency regardless of underlying distribution.
Calculate sha512-checksums for all files saved to ../log. Checksum of <file> are saved as <file>.sha512 . Unless the target file is IP-filtered or generated on localhost, checksumming is performed on the remote host.
Move hosts and ansible.cfg to hosts.template and ansible.cfg.template, add hosts and ansible.cfg to .gitignore. These files will always have to be changed by the user and therefore should not be part of the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
I've tried to make it so that benchmark-relevant packages are as independent of the underlying distribution as possible. To this end, I decided to use the current 1.x branch of sysbench for all distros instead of backporting (frontporting?) 0.4.x branch to the newer ones.