chore: move clsx dependency to caret/semver range #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philwolstenholme is attempting to deploy a commit to the Joe Bell OSS Team on Vercel. A member of the Team first needs to authorize it. |
|
Cheers Phil! I think that's a great shout Please could you do the same for |
philwolstenholme
force-pushed
the
main
branch
from
28db694
to
cb9a02d
Compare
Done! |
|
Oops sorry, I didn't spot the |
|
@philwolstenholme just run |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@joe-bell the lock file should be updated now! |
joe-bell
approved these changes
Nov 25, 2024
|
Shipped to |
|
Awesome, thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #317
I noticed when doing some bundle size analysis of my project that npm wasn't deduping my dependency of
clsxand CVA's dependency ofclsx.Was the dependency meant to be hardcoded to
2.1.0? This PR changes it to^2.1.0so that npm is free to deduplicate the dependency and share the same (major) version ofclsxacross my project code and CVA.Additional context
This saves users having to do something like this in their
package.jsonto override the duplicated dependency:{ "overrides": { "class-variance-authority": { "clsx": "^2.0.0" } } }What is the purpose of this pull request?