registry (threading): fix broken but passing test #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, while hacking on your framework I noticed these two tests were passing when they shouldn't have been. I realized that in both cases the tests were missing the actor ref fixture parameters, so no actors were ever added to the registry. The assertions inside the loops over the actor refs retrieved from the registry consequently never ran!
I've added the missing actor refs to both tests, plus some additional asserts to cover that the registry contains the expected actors.
Thanks for writing this excellent library (the code is extremely pleasant to work with, I can learn a lot from this). I hope you find this contribution useful.