Refactor Configuration for Filament Profile Editing and Avatar Handling #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update README.md - use of FILESYSTEM_DISK for disk to match default application filesystem disk. - use of fallback 'public' and not 'local' to avoid introducing breaking changes in existing installation - 'visibility' is 'public' while comment added to explain it can be updated - update `README.md` config's example
- use of fallback 'avatar_url' to avoid introducing breaking changes in existing installation - update example in `README.md`
refactor(config): add default config in filament-edit-profile.php and…
refactor(): add config for avatar. column name
|
@joaopaulolndev , could review please ? This PR address "Bug]: Possibilidade de inserir o nome da coluna do avatar #57" |
joaopaulolndev
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Introduced:
Default Configuration Update:
filament-edit-profile.php.README.mdwith configuration examples for clarity.Filesystem Configuration:
FILESYSTEM_DISKenvironment variable to match the application's default filesystem disk.'public'instead of'local'to prevent breaking changes in existing installations.visibilityas'public'with comments explaining it can be customized if needed.Avatar Configuration:
'avatar_url'.README.mdto reflect this new configuration option.