Make python version overridable by PYTHON variable #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current version builds both python versions if available. Failures are not fatal. Make it able to choose which version to compile, install only single version. Or no python code installed, if PYTHON= variable is passed.
pemensik
force-pushed
the
python
branch
2 times, most recently
from
7fca463
to
e601d9e
Compare
Change logic to provide both python2 and python3 in PYTHON variable. If set to empty, nothing is built. If set to specific, only that is built. Simplify logic. Makes a bit uglier error reports when something fails.
|
Just a note to say I'm busy doing other things at the moment but will get back to this within a week or so. |
|
I think is good idea to add variable PYTHON3 also |
|
The idea of PYTHON variable is to use it like PYTHON=python3 or PYTHON=python2. I am not sure what should PYTHON3 variable do. |
|
If PYTHON3 unset - do not build for python3. if setted - build it, by Can be usefull for yocto build. For example for native build python execulable call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version builds both python versions if available. Failures are
not fatal. Make it able to choose which version to compile, install only
single version. Or no python code installed, if PYTHON= variable is
passed.