Fix find_packages
#20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed it works :) |
jo-mueller
approved these changes
Jun 13, 2022
|
Hey @jaimergp , thanks for looking at this - and also good to know about this issue for future plugins! |
|
Preview page for your plugin is ready here: |
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 6 6
Lines 107 107
=======================================
Hits 103 103
Misses 4 4 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Hey @jaimergp , I changed the package structure of this plugin to using a |
|
Looks fine to me according to the docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am packaging 0.0.10 at conda-forge and the latest changes are making the CI fail. I think that
whereclause is only for packages that use asrc/structure, but otherwise not needed here. I'll confirm once I submit an attempt with this patch!