-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 21 Can't interrupt blocking accept #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the formatting throughout this PR to match how the rest of the code does it, please? Standard Java coding conventions, four space indentation, no tabs, etc.
Sorry this got left on the shelf so long. I submitted a review that needs some changes. |
Oh formatting again... sorry.... fixing... |
Signed-off-by: Greg Wilkins <[email protected]>
@headius can you re-review this one? |
@headius actually this is now not working reliably... so the fix is not good... but the issue is important. |
@gregw Sorry for dropping the ball on this but thank you for the update. I'll close this and we'll look at another fix. |
This is an attempted fix for #21
It does make it a little better as the testAcceptCloseInterrupt() test now sometimes passes (1 in 5 runs on my machine), but it has not fixed the problem generally.
Probably not worthwhile merging, just wanted to move #21 on.