Skip to content

Commit

Permalink
Resolve ignore-errors lint warnings
Browse files Browse the repository at this point in the history
This uses the apt lock workaround to replace an ignore_errors on update
and also just totally removes another ignore_errors for writing to the
.bashrcs of users. If that's failing, we probably need to make our
filter a bit better.
  • Loading branch information
laurelmay committed Aug 29, 2021
1 parent 38f871f commit a678196
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
5 changes: 3 additions & 2 deletions roles/common/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,6 @@
- name: Refresh apt cache
apt:
update_cache: yes
changed_when: false
ignore_errors: yes
register: apt_update
retries: 100
until: apt_update is success or ('Failed to lock apt for exclusive operation' not in apt_update.msg and '/var/lib/dpkg/lock' not in apt_update.msg)
1 change: 0 additions & 1 deletion roles/user/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@
# sources our profile. We won't create the file if it doesn't exist and
# we can ignore any errors
create: no
ignore_errors: yes
loop: "{{ real_users }}"
- name: Remove Timeshift warning
dconf:
Expand Down

0 comments on commit a678196

Please sign in to comment.