Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full AMD load support #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

artemkaint
Copy link

for RequireJS

@benkiefer
Copy link

Any chance we can get this merged? Or some variation of it?

@jmesnil
Copy link
Owner

jmesnil commented Nov 21, 2014

I'm ok with supporting AMD load support but I would like to do that outside of the stomp.coffee code.
I put the require support in it for CommonJS / NPM but regret the decision.
I would like to keep the stomp code agnostic of any package manager / framework and put that outside of the stomp.coffee file (and add any cake task to get a usable javascript file).

Ideally, I would like to keep stomp.coffee focus on STOMP code and have external files for the different flavours of JS packaging that can be maintained by external contributors (as I don't use any in my code).

@benkiefer
Copy link

Thanks for the direction. This is my first look at the code base (and cake), so I'm just starting to dig in now. I'll let you know if I have more questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants