Add a window for heartbeat pings and pongs #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not necessary to modify the timeout value for the heart-beat received from the broker, the library is tolerant and will not report a connection issue before 2 missing heart-beats (see https://github.com/jmesnil/stomp-websocket/blob/master/src/stomp.coffee#L143) If you modify your commit to only apply the heartbeatWindow to the heart-beat sent by the client, I will merge it. |
TrevorRawlings
pushed a commit
to TrevorRawlings/stomp-websocket
that referenced
this pull request
Jan 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues with my test system cosing the connection due to imprecise timing for the heartbeats. If the client using stomp.js says it will send a heartbeat every 10 seconds, the server killed the connection as soon as 10 seconds has elapsed. This was a problem because stomp.js was setting a timer for 10 seconds exactly but it wasn't sending the heartbeat in time.
The heartbeatWindow value allows you to specify a percentage difference. By default I set it to 10 percent, which will send a heartbeat every 9 seconds and expect a heartbeat every 11 seconds, if using the default 10 second values for the heartbeat negotiation.