Skip to content

Commit

Permalink
1.0.0 resubmit
Browse files Browse the repository at this point in the history
  • Loading branch information
jluchman committed Jul 10, 2022
1 parent 23f19e8 commit 22bb95b
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ cran-comments.md
^doc$
^Meta$
README.Rmd
^CRAN-SUBMISSION$
^CRAN-SUBMISSION$
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ domir(mpg ~ am + vs + cyl,

In `domir`, the `lm` model is not submitted directly. Rather, it is wrapped into a function (i.e., `lm_wrapper`) that, in this case, accepts two arguments; *formula* or an R formula and *data* a data frame in which the independent variables in the formula are present. The result of the `lm` is piped (i.e., `|>`) into the `summary` function and the result is captured as the object *result*. The *result* object is then filtered to just the **r.squared** element and returned.

What `domir` does automate taking subsets of the *formula* and submit them, repeatedly until all possible subsets have been submitted, to `lm_wrapper` (see this [vignette](https://cran.r-project.org/web/packages/domir/vignettes/domir_basics.html) for a conceptual discussion of dominance analysis). In this way, `domir` is a `Map`- or `lapply`-like function as it receives an object on which to operate (i.e., the *formula*) and a function to which to apply to it. `domir` expects a numeric scalar to be returned from the function.
What `domir` does automate taking subsets of the *formula* and submit them, repeatedly until all possible subsets have been submitted, to `lm_wrapper` (see this [vignette](https://CRAN.R-project.org/package=domir/vignettes/domir_basics.html) for a conceptual discussion of dominance analysis). In this way, `domir` is a `Map`- or `lapply`-like function as it receives an object on which to operate (i.e., the *formula*) and a function to which to apply to it. `domir` expects a numeric scalar to be returned from the function.

Like `lapply`, other arguments (`data = mtcars`) can also be passed to each call of the function and must be explicitly built into the wrapper function.

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ filtered to just the **r.squared** element and returned.
What `domir` does automate taking subsets of the *formula* and submit
them, repeatedly until all possible subsets have been submitted, to
`lm_wrapper` (see this
[vignette](https://cran.r-project.org/web/packages/domir/vignettes/domir_basics.html)
[vignette](https://CRAN.R-project.org/package=domir/vignettes/domir_basics.html)
for a conceptual discussion of dominance analysis). In this way, `domir`
is a `Map`- or `lapply`-like function as it receives an object on which
to operate (i.e., the *formula*) and a function to which to apply to it.
Expand Down
30 changes: 14 additions & 16 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## Major version update: 1.0.0
## Resubmission: Major version update: 1.0.0

In this resubmission of major update 1.0.0 I have fixed a web link to a vignette in the README.md file at the request of CRAN maintainers. This change has also removed one of the check NOTEs in the previous submission.

This major version update includes a new S3 generic function, `domir`, with a `print` and `summary` function and `formula` method. This new generic function supersedes the `domin` function.

Expand All @@ -18,12 +20,19 @@ Changes from version 0.3.2 also include:

## R CMD check results

Oracle Solaris with and without Oracle Developer Studio (rhub): 1 NOTE
Oracle Solaris with and without Oracle Developer Studio (rhub): 1 ERROR

* checking package dependencies ... ERROR
Package suggested but not available: ‘testthat’

* checking top-level files ... NOTE
Files ‘README.md’ or ‘NEWS.md’ cannot be checked without ‘pandoc’ being installed.
The suggested packages are required for a complete check.
Checking can be attempted without them by setting the environment
variable _R_CHECK_FORCE_SUGGESTS_ to a false value.

Comment: Appears to be a platform-specific build issue where the 'pandoc' program is not installed and thus cannot translate the .md formatted files.
See section ‘The DESCRIPTION file’ in the ‘Writing R Extensions’
manual.

Comment: Appears to be a platform-specific build issue where the 'testthat' package relied on for unit testing was not available resulting in a failed check on dependencies.

win-builder (devel, release, and old-release) and Oracle Solaris with and without Oracle Developer Studio (rhub): 1 NOTE

Expand All @@ -35,17 +44,6 @@ win-builder (devel, release, and old-release) and Oracle Solaris with and withou

Comment: Each word flagged as misspelled is an authors' name from cited literature discussing this methodology.

Found the following (possibly) invalid URLs:
URL: https://cran.r-project.org/web/packages/domir/vignettes/domir_basics.html
From: README.md
Status: 200
Message: OK
CRAN URL not in canonical form
The canonical URL of the CRAN page for a package is
https://CRAN.R-project.org/package=pkgname
Comment: The intention of this link is to point specifically at the vignette built and hosted on the CRAN webpage. It is my understanding that the canonical URL is to be used to point readers to the package broadly.

Found the following (possibly) invalid DOIs:
DOI: 10.1002/asmb.446
From: DESCRIPTION
Expand Down

0 comments on commit 22bb95b

Please sign in to comment.