Fix resolving radio tracks #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some internet radio streams like Radio Paradise, the total length of the track is not available. Also, sometimes the track name is in title2 field instead of title1 field if the stream name is in title1.
jliuhtonen
force-pushed
the
fix/resolving-radio-track-names
branch
from
adf9f1f to
69547b1
Compare
zquestz
reviewed
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some internet radio streams like Radio Paradise sometimes the track name is in title2 field instead of title1 field if the stream name is in title1. Also, the total length of the track might not be available. In this case, use 90 seconds as sensible default of when to scrobble as shorter songs are not that common.
This should address #85.