Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get spring training statcast data #405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ss77995ss
Copy link

Description

  • Spring training usually start from near 2/20 but the default range of start date is 3/15
  • Change the default from 3/15 to 2/15

* Spring training usually start from near 2/20 but the default range of start date is 3/15

* Change the default from 3/15 to 2/15
@ss77995ss
Copy link
Author

Hi @tjburch , @schorrm . Could you maybe have a look on this PR?
It will help us get complete spring training statcast data.

@tjburch
Copy link
Collaborator

tjburch commented Apr 1, 2024

Ran the CI. Seems like a fine change. I don't do a much here anymore, but if @schorrm doesn't pull the trigger in the next few days I'll merge it.

@schorrm
Copy link
Collaborator

schorrm commented Apr 1, 2024

Does the function filter out spring training? Can we?

@ss77995ss
Copy link
Author

ss77995ss commented Apr 2, 2024

Does the function filter out spring training? Can we?

They used argument hfGT to filter
Currently in pybaseball uses value &hfGT=R%7CPO%7CS%7C= (URL decode would be R|PO|S|=) which contains Regular Season, Spring Training and Playoff data

ref: pybaseball code, Baseball Savant's Search page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants