Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CityGML 3.0: Add support for missing elements #91

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

mlavik1
Copy link
Contributor

@mlavik1 mlavik1 commented Mar 21, 2024

Hi. We needed to support a wider range for CityGML 3.0 datasets, and I encountered some issues due to unimplemented elements. Here's a PR fixing those.

Relates issue: #89

Main additions:

Fixes:

  • Call setParserForNextElement for BLDG_BuildingPartNode
    • Fixes "bldg:buildingPart" being ignored when occurring directly under a "bldg:Building"

Models fixed/improved by this PR:

GEN multicurve/multisurface
intersection, section, waterway
GenericThematicSurface
call setParserForNextElement for buildingPart node
TrafficSpace + AuxiliaryTrafficSpace
tran:granularity
bldg:buildingConstructiveElement
bldg:buildingRoom
Con:WindowSurface
Con:DoorSurface
Handle BuildingInstallation child element
@mlavik1
Copy link
Contributor Author

mlavik1 commented Apr 4, 2024

Hi again @jklimke . I just updated my PR with some more changes. This should be my last change.
I added support for relativeGeometry (for ImplicitGeometry in CityGML 3.0), as well as some other surface types.

Feel free to let me know if you notice anything you want me to change.

@jklimke jklimke merged commit 146756f into jklimke:master Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants