Use volatile to prevent the compiler from optimizing alias pointers #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16
I suspect the compiler may have discarded line 44 due to optimizations, compiler ignoring the potential for pointer aliasing. I haven't confirmed from the disassembly, but this PR fixed the issue.
buddy-alloc/src/fast_alloc.rs
Lines 44 to 45 in 1a3e2e2
I have also modified the code of buddy alloc to prevent potentially similiar errors.
After the fix, the performance even improved 8% ~ 10% on my macbook, it is because we removed a
write_unaligned
.