-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup modules checking code #14
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 36.01% 36.01%
=======================================
Files 226 226
Lines 32187 32187
=======================================
Hits 11591 11591
Misses 20596 20596 Continue to review full report at Codecov.
|
@AhmadAlsaadi Thanks for this pull request. I think this project is interesting also. Is it possible for me to develop/test based on this branch? |
Yes sure.
…On Mon, 30 Apr 2018, 16:24 Jeroendevr, ***@***.***> wrote:
@AhmadAlsaadi <https://github.com/AhmadAlsaadi> Thanks for this pull
request. I think this project is interesting also. Is it possible for me to
develop/test based on this branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AMiQteg-tnRKST6zm_vt5nC540LUD6fqks5ttxB7gaJpZM4QXV1T>
.
--
This message and its contents, including attachments are intended solely
for the original recipient. If you are not the intended recipient or have
received this message in error, please notify me immediately and delete
this message from your computer system. Any unauthorized use or
distribution is prohibited. Please consider the environment before printing
this email.
|
dear JJgomera,
I thing this project is quite interesting and I would like to contribute to it. Even though I do not think that I will having much time to contribute regularly to it but I will try to do my best. Below is little description about my first pull request:
I did two things in this pull request:
first I was getting error when I run the program "it is about the global variable in the mainWindow.py file. I went around this error be commenting the global variable there.
second: I tried to shorten the code for checking required and optional modules in pychemqt file.
I used the same procedure that used for the optional modules for the required modules.
I modified the name of set in the tool.depences file from optional_modules to external_modules because I added to this set the data for the required modules.
I did not delete the old code and just comment it and labeled it with "not required anymore"
please let me know if you need further details.