Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup modules checking code #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cleanup modules checking code #14

wants to merge 1 commit into from

Conversation

AhmadAlsaadi
Copy link

dear JJgomera,
I thing this project is quite interesting and I would like to contribute to it. Even though I do not think that I will having much time to contribute regularly to it but I will try to do my best. Below is little description about my first pull request:

I did two things in this pull request:
first I was getting error when I run the program "it is about the global variable in the mainWindow.py file. I went around this error be commenting the global variable there.

second: I tried to shorten the code for checking required and optional modules in pychemqt file.
I used the same procedure that used for the optional modules for the required modules.
I modified the name of set in the tool.depences file from optional_modules to external_modules because I added to this set the data for the required modules.
I did not delete the old code and just comment it and labeled it with "not required anymore"

please let me know if you need further details.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 24.579% when pulling d7b0cef on AhmadAlsaadi:code_cleanup into e048915 on jjgomera:master.

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   36.01%   36.01%           
=======================================
  Files         226      226           
  Lines       32187    32187           
=======================================
  Hits        11591    11591           
  Misses      20596    20596

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e048915...d7b0cef. Read the comment docs.

@Jeroendevr
Copy link

@AhmadAlsaadi Thanks for this pull request. I think this project is interesting also. Is it possible for me to develop/test based on this branch?

@Jeroendevr Jeroendevr mentioned this pull request Apr 30, 2018
@AhmadAlsaadi
Copy link
Author

AhmadAlsaadi commented Apr 30, 2018 via email

jjgomera added a commit that referenced this pull request Sep 22, 2018
jjgomera added a commit that referenced this pull request Jan 19, 2023
jjgomera added a commit that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants