Fix performance of progress bar in Git fetch #5058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
force-pushed
the
push-lkrquxkrzuqm
branch
2 times, most recently
from
67fe8e0 to
997aa48
Compare
martinvonz
changed the title
Ralith
approved these changes
Dec 9, 2024
No, the issue in the existing code is that the |
|
Oh, wow, no idea what I(?) was thinking there. Nice catch. |
istudyatuni
reviewed
Dec 9, 2024
martinvonz
force-pushed
the
push-lkrquxkrzuqm
branch
from
997aa48 to
67f1c1d
Compare
The progress bar is supposed to update only 30 times per second, but as was reported in #5057, that doesn't seem to be what's happening. This patch adds tests showing how we update the progress bar for every event.
I think the idea of the code was try do 30 updates per second even if events arrive at, say, every 20 milliseconds. If we had reset the timer every time we printed, we would otherwise reset the timer every 40 milliseconds and end up with 25 updates per second. However, a bug in the code caused it to print every update because it always set the threshold to print the next update to `now`. I tried to keep what I think was the intent of the original code while fixing the bug.
martinvonz
force-pushed
the
push-lkrquxkrzuqm
branch
from
67f1c1d to
371044a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ralith, can you take a look and see if this preserves the behavior you intended?
Closes #5057.
Checklist
If applicable:
CHANGELOG.md