Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: duplicate: deprecate positional revisions argument #5022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Dec 4, 2024

(I'm not sure if this should be included in the next release.)

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@yuja yuja force-pushed the push-ynmkpvnkuymq branch from 8baa08b to b5dac16 Compare December 4, 2024 00:11
@martinvonz
Copy link
Member

(I'm not sure if this should be included in the next release.)

IMO, let's wait until after the release so people get a chance to comment.

Since the interface is now quite similar to "jj rebase", I think it's better to
require "-r". We might want to add "--source"/"--branch" later.
@yuja yuja force-pushed the push-ynmkpvnkuymq branch from b5dac16 to a2eea49 Compare December 5, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants