Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: git push: optionally describe commits that would fail push #5003

Merged

Conversation

shanesveller
Copy link
Contributor

First time-contributor, so feedback at any level of pedantry is fine while I adjust to the project norms!

Related to #5002.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Sorry, something went wrong.

@shanesveller shanesveller force-pushed the shanesveller/push-kwxtnswstlsx branch 3 times, most recently from 957c7b2 to 3f78e07 Compare November 29, 2024 22:25
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
@shanesveller shanesveller force-pushed the shanesveller/push-kwxtnswstlsx branch from 3f78e07 to 434667b Compare December 2, 2024 16:52
Copy link
Contributor

@yuja yuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cli/src/commands/git/push.rs Show resolved Hide resolved
cli/tests/test_git_private_commits.rs Show resolved Hide resolved
@shanesveller shanesveller force-pushed the shanesveller/push-kwxtnswstlsx branch 3 times, most recently from 6092275 to a95f32f Compare December 3, 2024 19:08
cli/src/commands/git/push.rs Outdated Show resolved Hide resolved
@shanesveller shanesveller force-pushed the shanesveller/push-kwxtnswstlsx branch from a95f32f to a115ea8 Compare December 4, 2024 14:42
@martinvonz
Copy link
Member

Looks like all comments have been addressed , so feel free to mark them resolved and then merge this PR

@shanesveller shanesveller merged commit 5553baf into jj-vcs:main Dec 4, 2024
18 checks passed
@shanesveller shanesveller deleted the shanesveller/push-kwxtnswstlsx branch December 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants