docs: clarify dynamic completion features #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
approved these changes
Nov 29, 2024
senekor
force-pushed
the
remo/wmpyztukklzw
branch
from
25963e2 to
878e7ab
Compare
|
Btw. I hard wrapped these lines because that seems to be the convention. I personally prefer one sentence per line. |
|
I had not heard of that convention until very recently. It was mentioned in a recent PR for the tutorial (I'll let you search for it). As I said there, I would be fine with changing to that convention. Whichever convention we choose, we should usually find a formatter that can automate it for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md