Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: move get_new_config_file_path() to commands::config #4992

Merged
merged 2 commits into from
Nov 30, 2024
Merged

cli: move get_new_config_file_path() to commands::config #4992

merged 2 commits into from
Nov 30, 2024

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Nov 28, 2024

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

yuja added 2 commits November 28, 2024 23:45
@yuja
config: update comment about new config file creation
36eaedb 
Spotted while updating get_new_config_file_path() callers. "jj config path"
isn't a command to create new config file.
@yuja
cli: move get_new_config_file_path() to commands::config
c51a486 
There aren't any other callers internally, and it is a thin wrapper around
ConfigEnv functions which can be easily implemented.
@yuja yuja merged commit 36e83ed into jj-vcs:main Nov 30, 2024
18 checks passed
@yuja yuja deleted the push-ymynwuwzmwyz branch November 30, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonz martinvonz martinvonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuja @martinvonz