git fetch: clarify errors with bad characters in globs and branch names
#4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyagr
commented
Nov 20, 2024
ilyagr
force-pushed
the
ig/branch-glob-doc
branch
2 times, most recently
from
c0af0b7 to
18f0c50
Compare
ilyagr
force-pushed
the
ig/branch-glob-doc
branch
from
18f0c50 to
a39b304
Compare
martinvonz
approved these changes
Nov 26, 2024
yuja
reviewed
Nov 26, 2024
ilyagr
force-pushed
the
ig/branch-glob-doc
branch
from
a39b304 to
4e5f853
Compare
I tried to clarify the text a bit as well.
Create a clearer error when a branch name contains `*`. Slightly clarify the error message for `?` in branch name/glob.
ilyagr
force-pushed
the
ig/branch-glob-doc
branch
from
4e5f853 to
893a162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are minor, but hopefully will make it clearer that fetch branch patterns
are unlike other bookmark patterns.
Checklist
If applicable:
CHANGELOG.md