completion: teach config about keys #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senekor
force-pushed
the
remo/kzvuxrrqnxuw
branch
from
cf7342b to
ec0b8b5
Compare
yuja
reviewed
Nov 17, 2024
senekor
force-pushed
the
remo/kzvuxrrqnxuw
branch
from
ec0b8b5 to
560e8d9
Compare
senekor
force-pushed
the
remo/kzvuxrrqnxuw
branch
from
560e8d9 to
a000137
Compare
There are two known limitations right now: - Only statically known keys are suggested. - Keys that the user did not set are still suggested for `jj config get`. Running that suggestion may result in an error. The error message will be appropriate though and there is some value in letting the user know that this config value theoretically exists. Some users may try to explore what configurations are available via the completions.
senekor
force-pushed
the
remo/kzvuxrrqnxuw
branch
from
a000137 to
5c9f80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two known limitations right now:
Only statically known keys are suggested.
Keys that the user did not set are still suggested for
jj config get. Running that suggestion may result in an error. The error message will be appropriate though and there is some value in letting the user know that this config value theoretically exists. Some users may try to explore what configurations are available via the completions.Checklist
If applicable:
CHANGELOG.md