Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: insert dummy -h/--help flag when parsing early args #4755

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

yuja
Copy link
Collaborator

@yuja yuja commented Nov 2, 2024

#4746

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Since 536c629 "cli: Explicitly add a Help command to accept the early args
after it", "jj help" is a normal subcommand.
Copy link
Collaborator

@ilyagr ilyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This looks good to me, I'll also ping @Grillo-0 in case they have any thoughts.

cli/src/cli_util.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Grillo-0 Grillo-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@yuja yuja force-pushed the push-olpwmtysykxm branch from 507e71b to dafa3b1 Compare November 3, 2024 04:21
@yuja yuja enabled auto-merge (rebase) November 3, 2024 04:21
@yuja yuja merged commit 15da697 into jj-vcs:main Nov 3, 2024
18 checks passed
@yuja yuja deleted the push-olpwmtysykxm branch November 3, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants