Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revset: add at_operation(op, expression) #4614

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

yuja
Copy link
Contributor

@yuja yuja commented Oct 9, 2024

#1283

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@yuja yuja force-pushed the push-wkltsoxxkzmp branch from b91e019 to 172a8bd Compare October 9, 2024 14:43
Copy link
Member

@martinvonz martinvonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for all your work on this feature.

lib/tests/test_revset.rs Outdated Show resolved Hide resolved
yuja added 2 commits October 11, 2024 16:28
…revset

This isn't fancy, but I couldn't find a better abstraction. Note that
MutableRepo::base_repo() isn't removed as it has to return &Arc<_>, whereas
<ReadonlyRepo as Repo>::base_repo() can't return &Arc<_>.
This can be used in order to refer old working-copy commit, for example. If
we find it's useful, maybe we can add an infix syntax later.

Closes jj-vcs#1283
@yuja yuja force-pushed the push-wkltsoxxkzmp branch from 172a8bd to 43cb954 Compare October 11, 2024 07:30
@yuja yuja merged commit f166fd0 into jj-vcs:main Oct 11, 2024
18 checks passed
@yuja yuja deleted the push-wkltsoxxkzmp branch October 11, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants