Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docs #4575

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix typo in docs #4575

merged 1 commit into from
Oct 3, 2024

Conversation

TheodoreEhrenborg
Copy link
Contributor

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

Copy link

google-cla bot commented Oct 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@PhilipMetzger
Copy link
Collaborator

Thanks for your contribution, but this is not a typo, as it recently was renamed. See 895d53f for the details.

@TheodoreEhrenborg
Copy link
Contributor Author

Aha, thanks for explaining

In that case, I've just changed file to files in the rest of that section, to match the rename

@PhilipMetzger
Copy link
Collaborator

If you can rewrite the commit description with docs: fix typo , I'll land it for you. See https://github.com/martinvonz/jj/blob/main/docs/contributing.md#code-reviews where I mean this part:

The commit message should describe the changes in the commit; the PR description can even be empty, but feel free to include a personal message. We write commit messages in an affected component style and don't use conventional commits. This means if you modified a command in the CLI, use its name as the topic, e.g next/prev: <your-modification> or conflicts: <your-modification>.

@martinvonz
Copy link
Member

If you can rewrite the commit description with docs: fix typo

I almost asked to update the description to be clearer but I didn't care enough. Since you're asking for an update anyway, I might as well. Can you make it docs: update stale references to singular file() revset or something like that? Thanks.

Copy link
Collaborator

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again.

@PhilipMetzger PhilipMetzger enabled auto-merge (rebase) October 3, 2024 20:28
@PhilipMetzger PhilipMetzger merged commit 3d26af8 into jj-vcs:main Oct 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants