diff: remove unneeded hash map lookup #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h keys We can assign a unique integer to each (word, occurrence) pair instead. As a bonus, HashMap can be replaced with Vec. ``` group new old ----- --- --- bench_diff_git_git_read_tree_c 1.00 72.5±3.25µs 1.08 78.5±0.48µs bench_diff_lines/modified/10k 1.00 45.1±1.18ms 1.10 49.8±1.85ms bench_diff_lines/modified/1k 1.00 4.1±0.07ms 1.11 4.5±0.34ms bench_diff_lines/reversed/10k 1.00 19.0±0.12ms 1.12 21.2±1.26ms bench_diff_lines/reversed/1k 1.00 558.5±37.42µs 1.17 655.6±16.27µs bench_diff_lines/unchanged/10k 1.00 5.3±0.78ms 1.33 7.0±0.89ms bench_diff_lines/unchanged/1k 1.00 422.0±16.68µs 1.28 540.7±13.96µs ```
This also allows us to borrow Vec<WordPositions> from &self.
Veykril
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md