Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsquash: deprecate in favor of squash and diffedit #4479

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Sep 15, 2024

Everything can be done with jj diffedit --restore-descendants and jj squash that could be done with jj unsquash.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@samueltardieu samueltardieu changed the title unsquash: deprecated in favor of squash unsquash: deprecate in favor of squash Sep 15, 2024
@PhilipMetzger
Copy link
Contributor

This is missing a meaningful deprecation message in jj unsquash, if we follow-through with it.

@samueltardieu
Copy link
Contributor Author

This is missing a meaningful deprecation message in jj unsquash, if we follow-through with it.

Right, fixed!

@samueltardieu
Copy link
Contributor Author

I've explicitly solicited reviews so that people can tell whether they think this is a good thing or not.

@yuja
Copy link
Contributor

yuja commented Sep 16, 2024

I've never used jj unsquash, so I have no idea if there are some edge cases which jj squash can't handle. I'm okay with the deprecation. In my mental model, "un-squash" == "split".

CHANGELOG.md Outdated Show resolved Hide resolved
@samueltardieu samueltardieu marked this pull request as draft September 17, 2024 08:26
@samueltardieu samueltardieu changed the title unsquash: deprecate in favor of squash unsquash: deprecate in favor of squash and diffedit Sep 24, 2024
@samueltardieu samueltardieu marked this pull request as ready for review September 24, 2024 07:32
Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

cli/src/commands/unsquash.rs Outdated Show resolved Hide resolved
cli/src/commands/diffedit.rs Show resolved Hide resolved
cli/src/commands/mod.rs Outdated Show resolved Hide resolved
cli/src/commands/unsquash.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@PhilipMetzger PhilipMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor nits from me.

cli/src/commands/diffedit.rs Show resolved Hide resolved
cli/src/commands/unsquash.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Everything that could be done with `jj unsquash` can be done with
`jj squash` or `jj diffedit --preserve-descendants`.
@samueltardieu samueltardieu merged commit baf25ba into jj-vcs:main Sep 26, 2024
18 checks passed
@samueltardieu samueltardieu deleted the deprecate-unsquash branch September 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants