-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unsquash: deprecate in favor of squash and diffedit #4479
Conversation
6444fcb
to
7624dd1
Compare
7624dd1
to
9bb9a02
Compare
This is missing a meaningful deprecation message in |
9bb9a02
to
3aa7634
Compare
Right, fixed! |
3aa7634
to
70caa3e
Compare
I've explicitly solicited reviews so that people can tell whether they think this is a good thing or not. |
70caa3e
to
1366ff3
Compare
I've never used |
1366ff3
to
6fbce53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
6fbce53
to
0b724e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor nits from me.
Everything that could be done with `jj unsquash` can be done with `jj squash` or `jj diffedit --preserve-descendants`.
0b724e6
to
2eadbd9
Compare
Everything can be done with
jj diffedit --restore-descendants
andjj squash
that could be done withjj unsquash
.Checklist
If applicable:
CHANGELOG.md