cli: Color more change and commit ids in cli outputs #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuja
reviewed
Sep 16, 2024
| write!(formatter, " to ")?; | ||
| format_commit_shortest_prefix(formatter, repo, id_prefix_context, new_target)?; | ||
| } | ||
| writeln!(formatter)?; |
There was a problem hiding this comment.
Perhaps, this function (and print_git_import_stats()) can be extracted to templates similar to bookmark_list.
Each (String, BookmarkPushUpdate) could be encoded as commit_templater::RefName, but it's probably better to add RefDiff or RefChange template type. In print_git_import_stats(), we'll need to represent a diff of remote-ref to remote-ref.
There was a problem hiding this comment.
Yes they ought to be all templated I noticed that after I was done with this current version (hence the draft).
Veykril
force-pushed
the
veykril/push-qyosyqnyuvom
branch
from
6ab5ab8 to
5ba0241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike #4444, this does not go through the relevant template. Should probably be doing that instead (though the template engine is pretty annoying to setup/use currently imo).
Checklist
If applicable:
CHANGELOG.md