workspace: turn WorkspaceLoader into a trait #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvonz
reviewed
Aug 29, 2024
torquestomp
force-pushed
the
dploch/workspace-loader
branch
from
3fe55f0 to
3b65247
Compare
torquestomp
force-pushed
the
dploch/workspace-loader
branch
from
3b65247 to
dab3a39
Compare
Like #4189, this allows extensions the ability to load the repo in an environment where the local filesystem is not accessible. This change allows such extensions to exist at the CLI layer where jj is invoked as a subprocess, rather than a library (common in testing).
torquestomp
force-pushed
the
dploch/workspace-loader
branch
from
dab3a39 to
bfefab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other changes, this small API change allows extensions to take over repo and working copy loading entirely when the factory types cannot be obtained through the local filesystem.
Checklist
If applicable:
CHANGELOG.md