Remove ReadonlyRepo::repo_path
#4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I messed up canonicalization. Will look into it later |
martinvonz
force-pushed
the
push-zmxutxospqvz
branch
from
6713df5 to
6d8ab26
Compare
That should be done now. I added canonicalization in |
yuja
approved these changes
Sep 7, 2024
martinvonz
force-pushed
the
push-zmxutxospqvz
branch
from
6d8ab26 to
f943423
Compare
…epo` I'd like to remove `ReadonlyRepo::repo_path()` since it doesn't make sense when the repo is stored in a database.
`RepoLoader` can be used on a server. You would then call `RepoLoader::new()`. Let's clarify what `init()` does by renaming it and documenting it. I think `WorkspaceLoader`, OTOH, is only useful for loading a workspace from disk. I also documented that.
In `TestBackend`, we simply use the path as key to look up the storage in memory. That means we can't rely on the file system to look find the same path given two different representaitons of the same path. We therefore need to canonicalize the paths if we want to allow the caller to pass in different paths for the same real path.
As I mentioned in recent patches, I'm about to remove `ReadonlyRepo::repo_path()`.
When loading repos on a server, there is no repo path. We currently use a placeholder at Google. This patch will let us not do that. I think we can remove the paths from `Workspace` too, but I'll leave that for later, if at all.
martinvonz
force-pushed
the
push-zmxutxospqvz
branch
from
f943423 to
5c18ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md