Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: bump the github-dependencies group with 2 updates #4200

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 2, 2024

Bumps the github-dependencies group with 2 updates: actions/upload-artifact and EmbarkStudios/cargo-deny-action.

Updates actions/upload-artifact from 4.3.4 to 4.3.5

Release notes

Sourced from actions/upload-artifact's releases.

v4.3.5

What's Changed

Full Changelog: actions/upload-artifact@v4.3.4...v4.3.5

Commits

Updates EmbarkStudios/cargo-deny-action from 1.6.3 to 2.0.0

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the github-dependencies group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [EmbarkStudios/cargo-deny-action](https://github.com/embarkstudios/cargo-deny-action).


Updates `actions/upload-artifact` from 4.3.4 to 4.3.5
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@0b2256b...89ef406)

Updates `EmbarkStudios/cargo-deny-action` from 1.6.3 to 2.0.0
- [Release notes](https://github.com/embarkstudios/cargo-deny-action/releases)
- [Commits](EmbarkStudios/cargo-deny-action@3f4a782...10d8902)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github-dependencies
- dependency-name: EmbarkStudios/cargo-deny-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Aug 2, 2024
@github-actions github-actions bot enabled auto-merge (rebase) August 2, 2024 15:24
@ilyagr
Copy link
Contributor

ilyagr commented Aug 2, 2024

I think this is the problem mentioned on Discord by @PhilipMetzger: our deny.toml uses an obsolete format. According to Philip, we need a PR like https://github.com/djc/askama/pull/973

Alternatively, we could ask Dependabot not to update the major version of cargo-deny-action.

@martinvonz
Copy link
Member

I sent #4202 to fix or work around it (I'm not sure which)

ilyagr added a commit to ilyagr/jj that referenced this pull request Aug 3, 2024
ilyagr added a commit to ilyagr/jj that referenced this pull request Aug 3, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 5, 2024

Superseded by #4217.

@dependabot dependabot bot closed this Aug 5, 2024
auto-merge was automatically disabled August 5, 2024 15:43

Pull request was closed

@dependabot dependabot bot deleted the dependabot/github_actions/github-dependencies-c63cfcec55 branch August 5, 2024 15:43
ilyagr added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants