FR: Add new revset builtin_immutable_heads()
#4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essiene
commented
Aug 1, 2024
martinvonz
reviewed
Aug 1, 2024
essiene
force-pushed
the
fr/4162
branch
3 times, most recently
from
086dced to
4f77a73
Compare
I've changed my approach. Instead of defining this in jj-lib, I'm now defining it as an alias in a new config source layer that takes precedence over all other config sources: builtins.toml So since it's just a regular alias, it can be defined in terms of wdyt? If this looks good, I'll go ahead to add some tests. |
essiene
changed the title
builtin_immutable_heads()builtin_immutable_heads()
yuja
reviewed
Aug 2, 2024
essiene
force-pushed
the
fr/4162
branch
10 times, most recently
from
ab4d64f to
89907b3
Compare
yuja
reviewed
Aug 12, 2024
essiene
force-pushed
the
fr/4162
branch
3 times, most recently
from
22f3838 to
10dfa89
Compare
* Add `builtin_immutable_heads()` in the `revsets.toml`. * Redefine `immutable_heads()` in terms of `builtin_immutable_heads()` * Warn if user redefines `builtin_immutable_heads()`, `mutable()` or `immutable()`. * Update module constant in revset_util.rs from BUILTIN_IMMUTABLE_HEADS to USER_IMMUTABLE_HEADS to avoid confusion since it points at `immutable_heads()` **and** we now have a revset-alias literally named `builtin_immutable_heads()`. * Add unittest * Update CHANGELOG * Update documentation. Fixes: #4162
Yw, and thanks again for the patient explanations. Much appreciated. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builtin_immutable_heads()in default config layer.immutable_heads()in terms ofbuiltin_immutable_heads()builtin_immutable_heads(),mutable()orimmutable()are redefined by the user.Fixes: #4162
Checklist
If applicable:
CHANGELOG.md