Expose some internal constructors #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the creation of Repo objects in environments without standard filesystem support, by allowing the caller to load the store objects however they see fit. This confines interaction with the filesystem to the WorkingCopy abstractions.
This allows constructing a workspace in a custom environment where the standard filesystem API cannot be used
torquestomp
force-pushed
the
dploch/repo_loader
branch
from
1f037cc to
14ca553
Compare
torquestomp
added a commit
that referenced
this pull request
Aug 30, 2024
Like #4189, this allows extensions the ability to load the repo in an environment where the local filesystem is not accessible. This change allows such extensions to exist at the CLI layer where jj is invoked as a subprocess, rather than a library.
torquestomp
added a commit
that referenced
this pull request
Aug 30, 2024
Like #4189, this allows extensions the ability to load the repo in an environment where the local filesystem is not accessible. This change allows such extensions to exist at the CLI layer where jj is invoked as a subprocess, rather than a library (common in testing).
torquestomp
added a commit
that referenced
this pull request
Aug 30, 2024
Like #4189, this allows extensions the ability to load the repo in an environment where the local filesystem is not accessible. This change allows such extensions to exist at the CLI layer where jj is invoked as a subprocess, rather than a library (common in testing).
torquestomp
added a commit
that referenced
this pull request
Aug 30, 2024
Like #4189, this allows extensions the ability to load the repo in an environment where the local filesystem is not accessible. This change allows such extensions to exist at the CLI layer where jj is invoked as a subprocess, rather than a library (common in testing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many places in jj_cli assume a working std::fs for interrogating repo storage types before loading the repos. Rather than abstract all of that away and introduce complexity, let's expose a couple simple constructor methods to allow a determined client to bypass std::fs interactions in environments that don't support them (for instance, when the repo is stored in a cloud filesystem that isn't mounted locally).
Checklist
If applicable:
CHANGELOG.md